Skip to content

Honor the parent make job limit when building PAX - #2378

Open
doefimov wants to merge 1 commit into
apache:mainfrom
doefimov:fix/pax-make-jobserver
Open

doefimov wants to merge 1 commit into
apache:mainfrom
doefimov:fix/pax-make-jobserver

Conversation

@doefimov

Copy link
Copy Markdown

What does this PR do?

Replace the hard-coded make -j8 and make -j10 calls in the PAX build and install recipes with $(MAKE) so both recursive invocations share the parent GNU Make job limit.

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

None.

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

With a parent make -j2:

  • Clean PAX builds succeeded before and after the patch. Peak concurrent compiler jobs dropped from 8 to 2.
  • Staged installs succeeded before and after the patch and produced the same file list.
  • With parallel work queued in a test fixture, peak jobs in the nested install target dropped from 10 to 2.

Impact

PAX build and install jobs now count toward the limit set by the parent make -jN.

Checklist

Additional Context

This change applies to the GNU Make/CMake build path.

Use recursive $(MAKE) for the CMake-generated build and install
targets so they inherit the parent jobserver. The fixed -j8 and
-j10 values bypassed the parent's limit.

@leborchuk leborchuk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants