Repository navigation
Fix flaky bitmap_index_crash isolation2 test - #2054
Merged
Merged
Conversation
Collaborator
|
Can you attach the link of failed CI test please or bug reproduction? |
Contributor
Author
Alena0704
approved these changes
Sep 30, 2026
Collaborator
leborchuk
approved these changes
Oct 1, 2026
leborchuk
left a comment
Contributor
There was a problem hiding this comment.
LGTM, see in tests
ok 67 - bitmap_index_concurrent 93767 ms
ok 68 - bitmap_index_crash 28778 ms
Member
|
Hi @krylosov-aa could you rebase and resolve the conflicts? Thanks! |
krylosov-aa
force-pushed
the
fix-isolation2
branch
from
November 20, 2026 12:43
a63af05 to
da145ac
Compare
Alena0704
enabled auto-merge (rebase)
November 20, 2026 14:52
Alena0704
force-pushed
the
fix-isolation2
branch
from
November 20, 2026 21:26
da145ac to
0cf5fc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Problem: during teardown, the test restarts content 1 with
pg_ctl restart -wand then immediately resets thecheckpointfault on all primaries.pg_ctl -wmay return as soon as crash recovery starts, even if the segment is not ready to accept connections yet.gp_inject_faultconnects directly to each segment and does not retry, so the reset can sometimes fail with an error likeconnection to ... failed.Regular queries do not have this issue because the dispatcher retries gang creation.
Solution: reset the
checkpointfault before the second restart. The second restart is only used for teardown and does not need the fault. Also, content 1 loses its fault state after the restart anyway.Type of Change
Test Plan
Local checks on Linux ARM64
Checklist