Skip to content

Fix flaky bitmap_index_crash isolation2 test - #2054

Merged
Alena0704 merged 1 commit into
apache:mainfrom
krylosov-aa:fix-isolation2
Nov 21, 2026
Merged

Alena0704 merged 1 commit into
apache:mainfrom
krylosov-aa:fix-isolation2

Conversation

@krylosov-aa

Copy link
Copy Markdown
Contributor

What does this PR do?

Problem: during teardown, the test restarts content 1 with pg_ctl restart -w and then immediately resets the checkpoint fault on all primaries.

pg_ctl -w may return as soon as crash recovery starts, even if the segment is not ready to accept connections yet. gp_inject_fault connects directly to each segment and does not retry, so the reset can sometimes fail with an error like connection to ... failed.

Regular queries do not have this issue because the dispatcher retries gang creation.

Solution: reset the checkpoint fault before the second restart. The second restart is only used for teardown and does not need the fault. Also, content 1 loses its fault state after the restart anyway.

Type of Change

  • Bug fix (non-breaking change)

Test Plan

Local checks on Linux ARM64

Checklist

@Alena0704 Alena0704 added the CI label Sep 29, 2026
@Alena0704

Alena0704 commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Can you attach the link of failed CI test please or bug reproduction?

@krylosov-aa

Copy link
Copy Markdown
Contributor Author

Here is https://github.com/apache/cloudberry/actions/runs/35835760210/job/107172195944

@Alena0704

Copy link
Copy Markdown
Collaborator

@Alena0704
Alena0704 requested a review from leborchuk September 30, 2026 17:25

@leborchuk leborchuk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see in tests

ok 67        - bitmap_index_concurrent                 93767 ms
ok 68        - bitmap_index_crash                      28778 ms

@Alena0704
Alena0704 requested a review from tuhaihe October 8, 2026 10:05
@tuhaihe

tuhaihe commented Nov 20, 2026

Copy link
Copy Markdown
Member

Hi @krylosov-aa could you rebase and resolve the conflicts? Thanks!

@Alena0704
Alena0704 enabled auto-merge (rebase) November 20, 2026 14:52
@Alena0704
Alena0704 merged commit 925f828 into apache:main Nov 21, 2026
136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants