Conversation
frankgh
commented
Sep 17, 2026
frankgh
commented
Sep 17, 2026
| CLASSPATH="$CLASSPATH:$CASSANDRA_HOME/build/test/lib/jars/*" | ||
|
|
||
| exec $NUMACTL "$JAVA" -Xmx8g -XX:+UseParallelGC -cp "$CLASSPATH" org.openjdk.jmh.Main -jvmArgs="-Djmh.shutdownTimeout=120 $cassandra_parms $JVM_OPTS" "$@" | ||
| if [ -n "${JMH_CLASSPATH_PREFIX:-}" ] ; then |
Contributor
Author
There was a problem hiding this comment.
this was added to make running JMH with custom classpaths and with additional options for JMH, for example profiling with gc enabled
frankgh
commented
Sep 17, 2026
Contributor
Author
There was a problem hiding this comment.
we can omit this file, but added it for reference . This was taking from @koo-taejin 's comment in JIRA
frankgh
commented
Sep 17, 2026
Contributor
Author
|
@koo-taejin can you take a look at this patch? |
netudima
reviewed
Sep 18, 2026
koo-taejin
reviewed
Sep 19, 2026
netudima
reviewed
Sep 19, 2026
netudima
reviewed
Sep 19, 2026
netudima
reviewed
Sep 19, 2026
Contributor
There was a problem hiding this comment.
nit: it looks like we still the file in the diff due to the last line change..
netudima
approved these changes
Sep 19, 2026
netudima
left a comment
netudima
left a comment
Contributor
There was a problem hiding this comment.
@koo-taejin @frankgh - thank you!
Carry clustering types as AbstractType<?>[] instead of List, so the hot path does an array load with no virtual dispatch and ClusteringComparator needs no defensive copy. patch by Taejin Koo and Francisco Guerrero; reviewed by Taejin Koo, Dmitry Konstantinov for CASSANDRA-21587 Co-authored-by: koo.taejin <koo.taejin@gmail.com>
frankgh
force-pushed
the
CASSANDRA-21587-trunk
branch
from
September 20, 2026 23:42
298e7ef to
89cb983
Compare
Contributor
Author
|
Closed via cc6eb8d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carry clustering types as AbstractType<?>[] instead of List, so the hot path does an array load with no virtual dispatch and ClusteringComparator needs no defensive copy.
patch by Taejin Koo and Francisco Guerrero; reviewed by TBD for CASSANDRA-21587
Co-authored-by: koo.taejin koo.taejin@gmail.com