Cassandra 21672 21677 21680 21681 6.0 zstd hardening - #5164
Open
smiklosovic wants to merge 6 commits into
Open
smiklosovic wants to merge 6 commits into
smiklosovic wants to merge 6 commits into
Conversation
This was referenced Sep 14, 2026
Contributor
Author
|
CASSANDRA-21672 patch (the first one) was already approved here: |
smiklosovic
force-pushed
the
CASSANDRA-21672-21677-21680-21681-6.0
branch
5 times, most recently
from
September 17, 2026 17:04
b5827a4 to
abe700b
Compare
yifan-c
reviewed
Sep 17, 2026
| compressor.pooledCompressContexts() <= threads); | ||
| assertTrue(compressor.pooledDecompressContexts() <= threads); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Please add the test cases to exercise when ok == false during compress and uncompress.
| // than a loser whose selfRef the cache would never own or release (CASSANDRA-21047 leak). | ||
| DictId newDictId = compressionDictionary.dictId(); | ||
| cache.get(newDictId, id -> { | ||
| CompressionDictionary cached = cache.get(newDictId, id -> { |
Contributor
There was a problem hiding this comment.
nit: just return w/o cached declaration?
Contributor
Author
There was a problem hiding this comment.
sorry i dont understand, there is logic following after this as well, we can not return immediately here, so we need to put this into cached for a while, no?
Contributor
There was a problem hiding this comment.
We cannot return here. You are right. I made a mistake when reading the code on the UI.
…chunk patch by Stefan Miklosovic; reviewed by Yifan Cai for CASSANRA-21672
smiklosovic
force-pushed
the
CASSANDRA-21672-21677-21680-21681-6.0
branch
from
September 18, 2026 10:23
abe700b to
80d92ef
Compare
patch by Stefan Miklosovic; reviewed by Yifan Cai for CASSANDRA-21677
…compressed SSTables concurrently patch by Stefan Miklosovic; reviewed by Yifan Cai for CASSANDRA-21680
…stale dictionary patch by Stefan Miklosovic; reviewed by Yifan Cai for CASSANDRA-21681
patch by Stefan Miklosovic; reviewed by Yifan Cai for CASSANDRA-21021
smiklosovic
force-pushed
the
CASSANDRA-21672-21677-21680-21681-6.0
branch
from
September 18, 2026 17:57
80d92ef to
a2830eb
Compare
smiklosovic
force-pushed
the
CASSANDRA-21672-21677-21680-21681-6.0
branch
from
September 18, 2026 19:07
a2830eb to
aa80706
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira