CASSPYTHON-24 Remove Insights support#1301
Open
absurdfarce wants to merge 1 commit into
Open
Conversation
absurdfarce
commented
Jul 15, 2026
| import re | ||
| import queue | ||
| import socket | ||
| import sys |
Contributor
Author
There was a problem hiding this comment.
A drive-by fix. I noticed these two imports were unused while working on CASSPYTHON-13 with Brett, figured I'd clean them up next time I was in this code.
| {key: ['{ip}:{port}'.format(ip=ip, port=port) for ip, port in value] | ||
| for key, value in strs_resolved_map.items() if value is not None} | ||
| ) | ||
| raise UnresolvableContactPoints(endpoint_map) |
Contributor
Author
There was a problem hiding this comment.
Seems weird to me that we were re-using an Insights map in the exception that's thrown here.. but apparently we were. Moved the logic into this block (so that it's only executed if an exception actually occurs) and moved everything out of class state.
| """ | ||
| A UUID that uniquely identifies this Session to Insights. This will be | ||
| generated automatically. | ||
| A UUID that uniquely identifies this Session. This will be generated automatically. |
Contributor
Author
There was a problem hiding this comment.
I had originally planned on removing this entirely but this ID is also used in column-level encryption (CLE)
Contributor
Author
|
Forgot to mention: Jenkins run on this change looks pretty good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.