Repository navigation
CAMEL-26864: camel-console - the processor-detail console names the route input by the id of its from, as the trace does - #29659
Merged
Conversation
…oute input by the id of its from, as the trace does The trace, the message history and the debugger name the from of a route by its node id (from1), while the processor-detail console named it by the route id, so an agent saw two ids for the same step. The TUI Diagram still finds the detail of the from by the route id it draws it with. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
gnodet-bot
reviewed
Nov 11, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Clean, well-tested fix that aligns the processor-detail console's from-node ID with the tracer and message history.
The fix correctly reads the id attribute from the <from> element in the route XML dump, with a safe fallback to routeId if the dump fails or the element has no id. DiagramDetailSupport.findProcessorEntry now handles both old-style (routeId) and new-style (node id like from1) lookups, preserving backward compatibility with apps on older Camel. Both tests are solid — ProcessorDetailFromIdTest confirmed failing before the fix (expected: <from1> but was: <myRoute>), and DiagramDetailFromIdTest covers five scenarios including the backward-compat case.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
Contributor
✅ Generated files are up to dateAn earlier CI run reported uncommitted generated changes; the latest run no longer does. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
gnodet-bot
reviewed
Nov 12, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
Contributor
There was a problem hiding this comment.
Previous findings are all addressed — the second commit correctly regenerates the metadata JSON to reflect the updated @Metadata description. LGTM.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
Contributor
|
🧪 CI tested the following changed modules:
🔁 1 test passed only after a retry on JDK 21 (1 retried attempt) Recovered flaky tests on JDK 21 (1)
🔬 Scalpel shadow comparison — Scalpel: 19 of 722 tested, 25 compile-only — current: 19 all testedMaveniverse Scalpel detected 19 affected modules (current approach: 19). Skip-tests mode would test 19 modules (4 direct + 17 downstream), skip tests for 25 (generated code, meta-modules) Modules Scalpel would test (19)
Modules with tests skipped (25)
All tested modules (46 modules, 7m 21s total)Total reactor time: 7m 21s
Top 20 slowest modules:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "two ids" part of item 15 of CAMEL-26864 (the rest is #29658).
The trace said nodeId
from1for the from of route hello, whiletui_get_processor_detailsaid its id ishello. The from has a node id of its own (from1, or the id given to it), and the tracer, the message history and the backlog debugger name it by that. Theprocessor-detaildeveloper console named it by the route id instead, which is already therouteIdof its response.processor-detail(type: from) has the id of the from, read from the route dump as the other processors are. The route id stays when the dump has no id for the from. The field description, its generated JSON and the catalog copy say so.The route structure (
route-structureconsole,ModelToStructureDumper) still names the from line by the route id: that id is how the console reads the route statistics of the line, and how the Diagram and the Source tab find the route, so changing it would ripple far for no gain to a user.Tests:
ProcessorDetailFromIdTest(camel-console, with JMX; fails without the fix:expected: <from1> but was: <myRoute>),DiagramDetailFromIdTest(TUI).Claude Code on behalf of Claus Ibsen
🤖 Generated with Claude Code