[CALCITE-7494] Avatica conversion to string of TIMESTAMP WITH TIME ZONE does not include time zone - #314
[CALCITE-7494] Avatica conversion to string of TIMESTAMP WITH TIME ZONE does not include time zone#314mihaibudiu wants to merge 1 commit into
Conversation
…NE does not include time zone Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
|
This affects the Calcite output, causing CI to fail. |
|
I guess I should first submit a helper PR in Calcite to disable the failing tests, and after merging this we can re-enable them. |
|
Whoever is reviewing this, please also check the failing CI test output, since it shows what the Calcite results will be in the future if we merge this. |
|
As I understand it, the issue is simply that Avatica was losing the "UTC" designation, so the goal of this PR (including the tests) is to verify that the fix preserves that designation. Therefore, there is no need to verify the correctness of the time zone handling itself (such as in the example below)—is that correct? |
|
Yes, this is right. This will need to be merged in 3 steps: disable calcite tests, merge this, enable calcite tests |
|
@mihaibudiu I can see that @xiedeyantu has approved this PR. Can you go ahead with the required merges to get this in? |
|
@F21 once we merge apache/calcite#5247 we can hopefully merge this as well. |
No description provided.