Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix RDMA polling initialization failure cleanup #3750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix RDMA polling initialization failure cleanup #3750
Changes from all commits
96d36d4File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting
runningtofalsebefore the old poller exits allows another initialization with the same tag to pass the entry CAS. Specifically, after A starts the first poller, creation of the second fails and A entersjoin. If B then initializes another Channel and setsrunningback totrue, the old poller, which has not yet observed the stop signal, will continue running, and A's initialization will remain blocked. Initializations of different Channels share thisPollerGroup, and the call chain has no serialization protection. Consider separating the stop signal from the initialization state to prevent the next batch of tasks from starting before rollback completes, and add a barrier-controlled concurrency test.Uh oh!
There was an error while loading. Please reload this page.