Stabilize butex stop-after-running test - #3562
Merged
chenBright merged 1 commit intoSep 23, 2026
Merged
Conversation
Member
Author
|
The failed |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
This PR stabilizes the stop_after_running butex test by removing scheduler-sensitive timing validation.
Changes:
- Removes the timer and wall-clock assertion.
- Retains
EINTR, stop, join, and repeated-stop checks.
| File | Description |
|---|---|
test/bthread_butex_unittest.cpp |
Stabilizes the stop-after-running test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
ButexTest.stop_after_runningassumes that stopping and joining a task finisheswithin 25 ms of a 10 ms sleep. The assertion is sensitive to scheduler delays
and has failed in CI exactly at the 25 ms boundary. The waiter already verifies
that
bthread_stop()interruptsbutex_wait()withEINTR, which is thebehavior under test.
What is changed and the side effects?
Changed:
Remove the wall-clock timing assertion and its timer while retaining the
EINTR, stop, join, and repeated-stop checks.Side effects:
Performance effects: None.
Breaking backward compatibility: No.
Check List: