Skip to content

explicitly link utf8_validity for Protobuf v22+ #3230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenBright merged 1 commit into from
Feb 26, 2026
+5 −0
Merged

explicitly link utf8_validity for Protobuf v22+ #3230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions config_brpc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,11 @@ GFLAGS_HDR=$(find_dir_of_header_or_die gflags/gflags.h)
PROTOBUF_HDR=$(find_dir_of_header_or_die google/protobuf/message.h)
PROTOBUF_VERSION=$(grep '#define GOOGLE_PROTOBUF_VERSION [0-9]\+' $PROTOBUF_HDR/google/protobuf/stubs/common.h | awk '{print $3}')
if [ "$PROTOBUF_VERSION" -ge 4022000 ]; then
# from v22, utf8_validity should be explicitly linked
# https://github.com/protocolbuffers/protobuf/blob/a847a8dc4ba1d99e7ba917146c84438b4de7d085/cmake/libprotobuf.cmake#L47
UTF8_VALIDITY_LIB=$(find_dir_of_lib utf8_validity)
append_linking "$UTF8_VALIDITY_LIB" utf8_validity

ABSL_HDR=$(find_dir_of_header_or_die absl/base/config.h)
ABSL_LIB=$(find_dir_of_lib_or_die absl_strings)
ABSL_TARGET_NAMES="
Expand Down
Loading