Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions sdks/python/apache_beam/io/iobase.py
Original file line number Diff line number Diff line change
Expand Up @@ -1716,15 +1716,19 @@ def total_work(self) -> float:
def fraction_completed(self) -> float:
if self._fraction is not None:
return self._fraction
else:
return float(self._completed) / self.total_work
total_work = self.total_work
if total_work == 0.:
return 1.0
return float(self._completed) / total_work

@property
def fraction_remaining(self) -> float:
if self._fraction is not None:
return 1 - self._fraction
else:
return float(self._remaining) / self.total_work
total_work = self.total_work
if total_work == 0.:
return 0.0
return float(self._remaining) / total_work

def with_completed(self, completed: int) -> 'RestrictionProgress':
return RestrictionProgress(
Expand Down
21 changes: 21 additions & 0 deletions sdks/python/apache_beam/io/iobase_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,5 +261,26 @@ def test_read_unbounded_serializes_as_expanded_composite(self):
self.assertTrue(read_transforms[0].subtransforms)


class RestrictionProgressTest(unittest.TestCase):
def test_restriction_progress(self):
# Total work == 0 edge cases (avoids ZeroDivisionError)
progress_zero_int = iobase.RestrictionProgress(completed=0, remaining=0)
self.assertEqual(progress_zero_int.fraction_completed, 1.0)
self.assertEqual(progress_zero_int.fraction_remaining, 0.0)

# Progress with completed and remaining
progress_work = iobase.RestrictionProgress(completed=25, remaining=75)
self.assertEqual(progress_work.completed_work, 25)
self.assertEqual(progress_work.remaining_work, 75)
self.assertEqual(progress_work.total_work, 100)
self.assertEqual(progress_work.fraction_completed, 0.25)
self.assertEqual(progress_work.fraction_remaining, 0.75)

# Progress with fraction
progress_frac = iobase.RestrictionProgress(fraction=0.4)
self.assertEqual(progress_frac.fraction_completed, 0.4)
self.assertAlmostEqual(progress_frac.fraction_remaining, 0.6)


if __name__ == '__main__':
unittest.main()
Loading