-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[GSoC 2026] Kafka Streams runner: surface SDK-harness metrics as MetricResults #39341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
je-ik
merged 3 commits into
apache:feat/18479-kafka-streams-runner-skeleton
from
junaiddshaukat:feat/ks-metrics
Jul 16, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
6024238
[GSoC 2026] Kafka Streams runner: surface SDK-harness metrics as Metr…
junaiddshaukat 48cd93c
Clarify thread-safety of the shared metrics step map in a comment
junaiddshaukat cf1fc30
Address review: DEBUG-log harness bundle progress and completion resp…
junaiddshaukat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
...-streams/src/test/java/org/apache/beam/runners/kafka/streams/translation/MetricsTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.beam.runners.kafka.streams.translation; | ||
|
|
||
| import static org.hamcrest.CoreMatchers.is; | ||
| import static org.hamcrest.MatcherAssert.assertThat; | ||
|
|
||
| import org.apache.beam.runners.kafka.streams.KafkaStreamsTestRunner; | ||
| import org.apache.beam.sdk.Pipeline; | ||
| import org.apache.beam.sdk.metrics.Counter; | ||
| import org.apache.beam.sdk.metrics.MetricNameFilter; | ||
| import org.apache.beam.sdk.metrics.MetricQueryResults; | ||
| import org.apache.beam.sdk.metrics.MetricResult; | ||
| import org.apache.beam.sdk.metrics.MetricResults; | ||
| import org.apache.beam.sdk.metrics.Metrics; | ||
| import org.apache.beam.sdk.metrics.MetricsFilter; | ||
| import org.apache.beam.sdk.transforms.Create; | ||
| import org.apache.beam.sdk.transforms.DoFn; | ||
| import org.apache.beam.sdk.transforms.ParDo; | ||
| import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.Iterables; | ||
| import org.junit.Test; | ||
|
|
||
| /** | ||
| * End-to-end test that user metrics reported by a {@link DoFn} in the SDK harness surface through | ||
| * the runner as {@link MetricResults}. | ||
| * | ||
| * <p>The harness reports metrics as Fn API MonitoringInfos with each bundle; the stage processor | ||
| * folds them into the job's metrics step map, and the runner exposes them as attempted {@link | ||
| * MetricResults}. This is the surface {@code PAssert} uses to verify its assertions actually ran, | ||
| * so it is a prerequisite for the {@code @ValidatesRunner} suite. | ||
| */ | ||
| public class MetricsTest { | ||
|
|
||
| private static final String NAMESPACE = "MetricsTest"; | ||
| private static final String COUNTER_NAME = "elements"; | ||
|
|
||
| /** Increments a user counter for every element the harness feeds it. */ | ||
| private static class CountingFn extends DoFn<Integer, Integer> { | ||
| private final Counter counter = Metrics.counter(NAMESPACE, COUNTER_NAME); | ||
|
|
||
| @ProcessElement | ||
| public void processElement(@Element Integer input, OutputReceiver<Integer> out) { | ||
| counter.inc(); | ||
| out.output(input); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void userCounterFromHarnessSurfacesInMetricResults() { | ||
| Pipeline pipeline = Pipeline.create(KafkaStreamsTestRunner.testOptions()); | ||
| pipeline.apply("create", Create.of(1, 2, 3)).apply("count", ParDo.of(new CountingFn())); | ||
|
|
||
| MetricResults metrics = KafkaStreamsTestRunner.run(pipeline); | ||
|
|
||
| MetricQueryResults query = | ||
| metrics.queryMetrics( | ||
| MetricsFilter.builder() | ||
| .addNameFilter(MetricNameFilter.named(NAMESPACE, COUNTER_NAME)) | ||
| .build()); | ||
| MetricResult<Long> counter = Iterables.getOnlyElement(query.getCounters()); | ||
| // Create.of(1, 2, 3) feeds the DoFn exactly three elements. | ||
| assertThat(counter.getAttempted(), is(3L)); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.