-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Support attributing BigQuery quota and billing to a custom GCP project (Python, Java, Go) #39203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shahar1
wants to merge
9
commits into
apache:master
Choose a base branch
from
shahar1:gcp-set-quota-project-python
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f847ba5
Set quota project in beam.io.ReadFromBigQuery in Python SDK
shahar1 324dbeb
Fix isort linting
shahar1 12e2845
Document quota_project_id in ReadFromBigQuery and simplify client init
shahar1 7448804
Add bigQueryQuotaProjectId pipeline option to Java BigQueryIO
shahar1 d1a3cc9
Add WithQuotaProject read option to Go bigqueryio
shahar1 0f949cc
Pass transform-level quota_project_id to the BigQuery jobs client
shahar1 0a82c97
Improve test coverage for quota project support across SDKs
shahar1 2a069cb
Merge master into gcp-set-quota-project-python
shahar1 70be9f9
Address review: fail loudly on quota project, centralize client creation
shahar1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -82,6 +82,59 @@ def get_service_credentials(pipeline_options): | |
| return _Credentials.get_service_credentials(pipeline_options) | ||
|
|
||
|
|
||
| def with_quota_project(credentials, quota_project_id): | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cache _quota_credentials same as _credentials? |
||
| """For internal use only; no backwards-compatibility guarantees. | ||
|
|
||
| Apply a quota project to credentials if supported. | ||
|
|
||
| The quota project is used to bill API requests to a specific GCP project, | ||
| separate from the project that owns the service account or data. | ||
|
|
||
| Args: | ||
| credentials: The credentials object (either _ApitoolsCredentialsAdapter | ||
| or a google.auth credentials object). | ||
| quota_project_id: The GCP project ID to use for quota and billing. | ||
|
|
||
| Returns: | ||
| Credentials with the quota project applied, or the original credentials | ||
| if no quota project was requested. | ||
|
|
||
| Raises: | ||
| ValueError: If a quota project was requested but cannot be applied. | ||
| Ignoring the request would silently bill a different project. | ||
| """ | ||
| if quota_project_id is None: | ||
| return credentials | ||
|
|
||
| if not _GOOGLE_AUTH_AVAILABLE: | ||
| raise ValueError( | ||
| 'quota_project_id was set to %r, but the google-auth library is not ' | ||
| 'installed, so it cannot be applied.' % quota_project_id) | ||
|
|
||
| if credentials is None: | ||
| raise ValueError( | ||
| 'quota_project_id was set to %r, but no credentials were found to ' | ||
| 'apply it to.' % quota_project_id) | ||
|
|
||
| # Get the underlying google-auth credentials if wrapped | ||
| if hasattr(credentials, 'get_google_auth_credentials'): | ||
| underlying_creds = credentials.get_google_auth_credentials() | ||
| else: | ||
| underlying_creds = credentials | ||
|
|
||
| if not hasattr(underlying_creds, 'with_quota_project'): | ||
| raise ValueError( | ||
| 'quota_project_id was set to %r, but credentials of type %s do not ' | ||
| 'support a quota project.' % | ||
| (quota_project_id, type(underlying_creds).__name__)) | ||
|
|
||
| new_creds = underlying_creds.with_quota_project(quota_project_id) | ||
| # Re-wrap if the original was wrapped | ||
| if hasattr(credentials, 'get_google_auth_credentials'): | ||
| return _ApitoolsCredentialsAdapter(new_creds) | ||
| return new_creds | ||
|
|
||
|
|
||
| if _GOOGLE_AUTH_AVAILABLE: | ||
|
|
||
| class _ApitoolsCredentialsAdapter: | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this safe from caching? Should we rather set the header directly in the newBigQueryClient initBuilder?