Skip to content

Pin flaky Python unit tests to FnApiRunner to avoid Prism gRPC deadli…#38126

Draft
aIbrahiim wants to merge 5 commits intoapache:masterfrom
aIbrahiim:fix-python-precommit-prism-deadline-timeouts
Draft

Pin flaky Python unit tests to FnApiRunner to avoid Prism gRPC deadli…#38126
aIbrahiim wants to merge 5 commits intoapache:masterfrom
aIbrahiim:fix-python-precommit-prism-deadline-timeouts

Conversation

@aIbrahiim
Copy link
Copy Markdown
Contributor

…ne timeouts

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the stability of Python unit tests by providing a mechanism to bypass the PrismRunner when using the DirectRunner. By introducing a new pipeline option, --no_direct_runner_use_prism, and applying it to specific tests, the changes mitigate flakiness often observed in CI environments due to gRPC deadline timeouts associated with PrismRunner's subprocess execution. This ensures more reliable test outcomes without altering the default behavior for production pipelines.

Highlights

  • New Pipeline Option for PrismRunner Control: A new pipeline option, --no_direct_runner_use_prism, has been introduced. This option allows users to explicitly disable the use of PrismRunner when running pipelines with the DirectRunner, providing more control over execution environments.
  • Conditional PrismRunner Execution in DirectRunner: The DirectRunner has been updated to respect the newly added direct_runner_use_prism option. This change enables the DirectRunner to bypass PrismRunner and its associated gRPC subprocess path when the option is set to false, allowing for in-process execution.
  • Improved Test Stability: Several Python unit tests, specifically in bigquery_test.py and yaml_transform_unit_test.py, have been modified to explicitly disable PrismRunner. This change addresses test flakiness caused by gRPC deadline timeouts, ensuring more reliable and stable test results in CI environments.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@aIbrahiim aIbrahiim force-pushed the fix-python-precommit-prism-deadline-timeouts branch from 009e37e to f6385fd Compare April 9, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant