-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Add PreCommit Java Dataflow workflow (#38094) #38124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
liferoad
wants to merge
5
commits into
master
Choose a base branch
from
fix/beam-38094-slow-streaming-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+135
−0
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
935b8a4
Add PreCommit Java Dataflow workflow (#38094)
liferoad a1a574d
Add release/trigger_all_tests.json to trigger path per GHA validation
liferoad 66b3134
Exclude Dataflow worker from main Java PreCommit (#38094)
liferoad 0671ed9
Add beam_PreCommit_Java_Dataflow.yml to workflows/README.md
liferoad 9cd41d2
Address PR review comments: rename, ubuntu-24.04, drop trigger file
liferoad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or or in writing, software | ||
| # distributed under the License is distributed on an "AS IS" | ||
| # BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| # express or implied. See the License for the specific language | ||
| # governing permissions and limitations under the License. | ||
|
|
||
| name: PreCommit Java Dataflow Non-portable Worker | ||
|
|
||
| on: | ||
| push: | ||
| tags: ['v*'] | ||
| branches: ['master', 'release-*'] | ||
| paths: | ||
| - 'runners/google-cloud-dataflow-java/worker/**' | ||
| - '.github/workflows/beam_PreCommit_Java_Dataflow.yml' | ||
| pull_request_target: | ||
| branches: ['master', 'release-*'] | ||
| paths: | ||
| - 'runners/google-cloud-data-dataflow-java/worker/**' | ||
| - '.github/workflows/beam_PreCommit_Java_Dataflow.yml' | ||
| issue_comment: | ||
| types: [created] | ||
| schedule: | ||
| - cron: '30 2/6 * * *' | ||
| workflow_dispatch: | ||
|
|
||
| concurrency: | ||
| group: '${{ github.workflow }} @ ${{ github.event.pull_request.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login }}' | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| actions: write | ||
| pull-requests: write | ||
| checks: write | ||
| contents: read | ||
| deployments: read | ||
| id-token: none | ||
| issues: write | ||
| discussions: read | ||
| packages: read | ||
| pages: read | ||
| repository-projects: read | ||
| security-events: read | ||
| statuses: read | ||
|
|
||
| env: | ||
| DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }} | ||
| GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }} | ||
| GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }} | ||
|
|
||
| jobs: | ||
| beam_PreCommit_Java_Dataflow: | ||
| name: ${{ matrix.job_name }} (${{ matrix.job_phrase }}) | ||
| runs-on: [self-hosted, ubuntu-24.04, main] | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| job_name: [beam_PreCommit_Java_Dataflow_NonportableWorker] | ||
| job_phrase: [Run Java Dataflow Non-portable Worker PreCommit] | ||
| timeout-minutes: 240 | ||
| if: | | ||
| github.event_name == 'push' || | ||
| github.event_name == 'pull_request_target' || | ||
| (github.event_name == 'schedule' && github.repository == 'apache/beam') || | ||
| github.event_name == 'workflow_dispatch' || | ||
| github.event.comment.body == 'Run Java Dataflow Non-portable Worker PreCommit' | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Setup repository | ||
| uses: ./.github/actions/setup-action | ||
| with: | ||
| comment_phrase: ${{ matrix.job_phrase }} | ||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||
| github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }}) | ||
| - name: Setup environment | ||
| uses: ./.github/actions/setup-environment-action | ||
| with: | ||
| python-version: default | ||
| disable-cache: true | ||
| - name: Run Dataflow Worker tests | ||
| uses: ./.github/actions/gradle-command-self-hosted-action | ||
| with: | ||
| gradle-command: :runners:google-cloud-dataflow-java:worker:test | ||
| arguments: | | ||
| -PdisableSpotlessCheck=true \ | ||
| -PdisableCheckStyle=true \ | ||
| -PenableJacocoReport \ | ||
| - name: Archive JUnit Test Results | ||
| uses: actions/upload-artifact@v4 | ||
| if: ${{ !success() }} | ||
| with: | ||
| name: JUnit Test Results | ||
| path: "**/build/reports/tests/" | ||
| - name: Publish JUnit Test Results | ||
| uses: EnricoMi/publish-unit-test-result-action@v2 | ||
| if: always() | ||
| with: | ||
| commit: '${{ env.prsha || env.GITHUB_SHA }}' | ||
| comment_mode: ${{ github.event_name == 'issue_comment' && 'always' || 'off' }} | ||
| files: '**/build/test-results/**/*.xml' | ||
| large_files: true | ||
| - name: Archive SpotBugs Results | ||
| uses: actions/upload-artifact@v4 | ||
| if: always() | ||
| with: | ||
| name: SpotBugs Results | ||
| path: '**/build/reports/spotbugs/*.html' | ||
| - name: Publish SpotBugs Results | ||
| uses: jwgmeligmeyling/spotbugs-github-action@v1.2 | ||
| if: always() | ||
| with: | ||
| name: Publish SpotBugs | ||
| path: '**/build/reports/spotbugs/*.html' | ||
| - name: Archive Jacoco Results | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: Jacoco Results | ||
| path: '**/build/jacoco/report/**' | ||
| - name: Upload coverage reports to Codecov | ||
| uses: codecov/codecov-action@v3 | ||
| with: | ||
| flags: java | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I mean the json file is not needed to be created for this PR. The json file trigger path is still good to hive, in alignment with other workflows