Skip to content

Conversation

@Prakash1185
Copy link
Contributor

Problem

  • The site footer layout was breaking on smaller screens and footer links were misaligned.

What changed

  • Applied mobile-only layout adjustments to the footer
  • Centered footer content on small screens
  • All the changes made does not affect the desktop layout.

Before

Screenshot 2026-01-17 033844 Screenshot 2026-01-17 033922

After

Screenshot 2026-01-17 033830 Screenshot 2026-01-17 033926

@Prakash1185
Copy link
Contributor Author

Hi @martin-g , this PR improves footer responsiveness on small screens. Please take a look.

margin-right: auto;
display: block;
}
} No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

font-family: "PT Mono", monospace;
}

@media (max-width: 996px) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the breakpoint to 992px to match Bootstrap’s lg breakpoint.

display: flex;
flex-direction: column;
align-items: center;
text-align: center;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
text-align: center;

This one seems redundant. The one at line 49 will override it anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, removed the redundant text-align rule.

text-align: center;
}

footer [class^="col-"] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will match only if "col-..." is the first item in class="...", e.g. class="col-3", but it won't match for class="another col-3"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. Updated the selector to avoid relying on class name prefixes.

}

footer [class^="col-"] {
width: 100% !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important is usually not recommended. Did you try without it ? E.g. with more concrete selector.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed !important and adjusted the selector accordingly.

margin: 0.4rem;
}

footer img {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed ?
<img> is an inline element, so the text-align: center from line 49 should be enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the unnecessary img centering rule.

@Prakash1185
Copy link
Contributor Author

Thanks for the detailed review! I’ve noted the points and will address them shortly with an updated commit.

@github-actions github-actions bot added C++ Pull Requests for C++ binding Java Pull Requests for Java binding build Python C# PHP C JS labels Jan 23, 2026
@Prakash1185 Prakash1185 force-pushed the fix/footer-responsive-fix branch from 0d0baaf to ecaba14 Compare January 23, 2026 15:41
@github-actions github-actions bot removed C++ Pull Requests for C++ binding Java Pull Requests for Java binding build Python C# C labels Jan 23, 2026
@Prakash1185
Copy link
Contributor Author

Prakash1185 commented Jan 23, 2026

Thanks for the review! @martin-g . I’ve pushed an update addressing all the changes you suggested and the final footer layout is same as with the previous css code. Please let me know if this looks good now.

@martin-g martin-g merged commit 063695a into apache:main Jan 24, 2026
2 checks passed
@martin-g
Copy link
Member

Thank you, @Prakash1185 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants