[AURON #2521] Fix NULL predicate handling in aggregate filters - #2522
Open
lyne7-sc wants to merge 2 commits into
Open
[AURON #2521] Fix NULL predicate handling in aggregate filters#2522lyne7-sc wants to merge 2 commits into
lyne7-sc wants to merge 2 commits into
Conversation
richox
approved these changes
Sep 11, 2026
cxzl25
approved these changes
Sep 11, 2026
| // Single accumulator for all rows in this group. | ||
| IdxSelection::Single(idx) => { | ||
| for i in batch_start_idx..batch_end_idx { | ||
| if filter_array.value(i) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2521
Rationale for this change
Aggregate FILTER may include NULL predicates when their underlying boolean value bits are true. For example, FILTER (WHERE NOT flag) can produce incorrect SUM and COUNT results for nullable flag columns.
What changes are included in this PR?
Are there any user-facing changes?
Aggregate filters exclude NULL predicates, matching Spark.
How was this patch tested?
Added end-to-end tests comparing native SUM/COUNT with Spark for nullable filters, with and without GROUP BY.
Was this patch authored or co-authored using generative AI tooling?
If yes, include:
Generated-by: Openai codex gpt-6-astraASF guidance: https://www.apache.org/legal/generative-tooling.html