ARTEMIS-6068 Broker plugins do not receive updated properties on broker.xml reload#6455
Open
mbengtsson wants to merge 1 commit into
Open
ARTEMIS-6068 Broker plugins do not receive updated properties on broker.xml reload#6455mbengtsson wants to merge 1 commit into
mbengtsson wants to merge 1 commit into
Conversation
…er.xml reload Broker plugins have no way to learn that their configured properties changed when broker.xml is reloaded. Store parsed class names and properties during reload. Notify matching running plugin instances via a new propertiesReloaded(Map<String, String>) callback on ActiveMQServerBasePlugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/ARTEMIS-6068
This closes a gap in the existing broker.xml reload model. Artemis already reloads several broker-managed configuration areas, but broker plugin properties are only delivered during plugin initialization.
Without a dedicated reload callback, plugins that need to react to changed configuration must implement their own file watching and parsing logic outside the broker.
This change adds propertiesReloaded(Map<String, String>) as a callback on ActiveMQServerBasePlugin and invokes it for matching already-running plugin instances during broker.xml reload.
The existing broker-plugin XML format is preserved. Matching is by class name because broker-plugin entries currently have no name/id attribute.
Tests: BrokerPluginReloadTest