ARTEMIS-5947: Fix newActiveMQServer(String,...) ignoring XML persistence-enabled setting#6286
Merged
clebertsuconic merged 2 commits intomainfrom Mar 11, 2026
Merged
Conversation
…nce-enabled setting The 3-arg newActiveMQServer(String, MBeanServer, ActiveMQSecurityManager) method was calling the 3-arg newActiveMQServer(Configuration, MBeanServer, SecurityManager) which hardcodes enablePersistence=true, overriding whatever was parsed from the XML configuration file. Changed to call the 4-arg version with config.isPersistenceEnabled() to preserve the XML setting.
jbertram
reviewed
Mar 10, 2026
artemis-server/src/test/java/org/apache/activemq/artemis/core/server/ActiveMQServersTest.java
Outdated
Show resolved
Hide resolved
Contributor
|
@gnodet thanks a lot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActiveMQServers.newActiveMQServer(String, MBeanServer, ActiveMQSecurityManager)was calling the 3-argnewActiveMQServer(Configuration, MBeanServer, SecurityManager)which hardcodesenablePersistence=true, overriding whatever was parsed from XML (e.g.<persistence-enabled>false</persistence-enabled>)config.isPersistenceEnabled()to preserve the XML settingpersistence-enabled=falsefrom XML config is respectedTest plan
ActiveMQServersTest.testNewActiveMQServerFromConfigURLRespectsXmlPersistenceEnabledpasses