Repository navigation
GH-55267: [C++][R] Arrow 26.0.0 fails to build on CRAN macOS builders: bundled simdjson C++20 concepts don't compile with the macOS 11 SDK - #55273
Conversation
|
|
There was a problem hiding this comment.
🟢 Approval recommended
The narrow regex change covers both documented SDK names, excludes other macOS major versions, and introduces no identified blocking issues.
No open issues 🎉
What changed in this PR
This PR fixes the bundled simdjson SDK check for CRAN macOS builds by extending the existing C++20 concepts workaround to recognize MacOSX11.sdk.
Changes:
- Broadens the regex to match macOS 11 SDK names with or without a minor version, preserving support for
MacOSX11.3.sdk. - Updates the explanatory comments and status message to reflect macOS 11 coverage.
| File | Description |
|---|---|
cpp/cmake_modules/ThirdpartyToolchain.cmake |
Broadens macOS 11 SDK detection for the existing simdjson concepts workaround. |
Review effort: Balanced
|
@github-actions crossbow submit test-r-macos-as-cran |
|
Revision: 99ff206 Submitted crossbow builds: ursacomputing/crossbow @ actions-31b1457ca7
|
|
Actually, the submitted CI job will fail because of #53945 but I've tested the regex locally and am happy with it |
Nah, we don't need #53946 as the PR which added the functionality which broke our CRAN builds wasn't in 26.0.0 |
Rationale for this change
CRAN failures on 26.0.0 release due to regex not catching incompatible MacOSX11.sdk version
What changes are included in this PR?
Make regex more permissive
Are these changes tested?
No
Are there any user-facing changes?
No
PR code and description written by:
Reviewed before submission by: