Skip to content

GH-55267: [C++][R] Arrow 26.0.0 fails to build on CRAN macOS builders: bundled simdjson C++20 concepts don't compile with the macOS 11 SDK - #55273

Merged
thisisnic merged 4 commits into
apache:mainfrom
thisisnic:GH-55267-simdjson-sdk-regex
Oct 27, 2026
Merged

thisisnic merged 4 commits into
apache:mainfrom
thisisnic:GH-55267-simdjson-sdk-regex

Conversation

@thisisnic

@thisisnic thisisnic commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Rationale for this change

CRAN failures on 26.0.0 release due to regex not catching incompatible MacOSX11.sdk version

What changes are included in this PR?

Make regex more permissive

Are these changes tested?

No

Are there any user-facing changes?

No

PR code and description written by:

  • Human
  • AI

Reviewed before submission by:

  • Human
  • AI
  • Not reviewed

Copilot AI balanced review requested due to automatic review settings October 26, 2026 16:41
@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label Oct 26, 2026
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #55267 has been automatically assigned in GitHub to PR creator.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrow regex change covers both documented SDK names, excludes other macOS major versions, and introduces no identified blocking issues.

No open issues 🎉

What changed in this PR

This PR fixes the bundled simdjson SDK check for CRAN macOS builds by extending the existing C++20 concepts workaround to recognize MacOSX11.sdk.

Changes:

  • Broadens the regex to match macOS 11 SDK names with or without a minor version, preserving support for MacOSX11.3.sdk.
  • Updates the explanatory comments and status message to reflect macOS 11 coverage.
File Description
cpp/​cmake_modules/​ThirdpartyToolchain.cmake Broadens macOS 11 SDK detection for the existing simdjson concepts workaround.

Review effort: Balanced

@thisisnic
thisisnic marked this pull request as draft October 26, 2026 16:46
@thisisnic
thisisnic marked this pull request as ready for review October 27, 2026 12:13
Copilot AI balanced review requested due to automatic review settings October 27, 2026 12:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrow regex change covers the reported CRAN path, preserves the existing CI match, and has no identified blocking issues.

No open issues 🎉

Review effort: Balanced

@thisisnic

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

Copy link
Copy Markdown

Revision: 99ff206

Submitted crossbow builds: ursacomputing/crossbow @ actions-31b1457ca7

Task Status
test-r-macos-as-cran GitHub Actions

@thisisnic

thisisnic commented Oct 27, 2026 •

Copy link
Copy Markdown
Member Author

Actually, the submitted CI job will fail because of #53945 but I've tested the regex locally and am happy with it

@thisisnic thisisnic added this to the 26.0.1 milestone Oct 27, 2026
Copilot AI balanced review requested due to automatic review settings October 27, 2026 12:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The localized guard change covers CRAN’s reported SDK path, preserves the existing CI match, and has no identified blocking issues.

No open issues 🎉

Review effort: Balanced

@jonkeane jonkeane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Actually, the submitted CI job will fail because of #53945 but I've tested the regex locally and am happy with it

We are planning to include both this and #53946 (the PR for #53945) in the patch, yeah?

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 27, 2026
@thisisnic

Copy link
Copy Markdown
Member Author

Thanks for this!

Actually, the submitted CI job will fail because of #53945 but I've tested the regex locally and am happy with it

We are planning to include both this and #53946 (the PR for #53945) in the patch, yeah?

Nah, we don't need #53946 as the PR which added the functionality which broke our CRAN builds wasn't in 26.0.0

@thisisnic
thisisnic merged commit 2ecb29d into apache:main Oct 27, 2026
59 checks passed
@thisisnic thisisnic removed the awaiting merge Awaiting merge label Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants