Repository navigation
Conversation
|
Thanks for opening a pull request! This pull request has been automatically converted to a draft because its title doesn't match Arrow's required format. If this is not a minor PR, could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or After updating the title, you can mark the pull request as ready for review. See also: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parquet LIST columns that are effectively fixed-length currently pay the full Dremel reconstruction cost on every read. This change adds a page-level fixed-length detector and a direct child-value path for vector-shaped LIST data.
The reader validates all-present definition levels and the periodic repetition-level pattern, derives the list width, then reads values directly across pages and constructs offsets with a fixed stride. The detector handles V1/V2 page boundaries, including pages that continue a list from the previous page.
The optimization is controlled by
ArrowReaderProperties::set_fixed_list_fast_path()and is disabled by default. If enabled for a variable-width LIST and a later page changes width after values have been consumed, the reader returns an explicit error instructing callers to disable the property.Validation
make -C cpp/build-release -j8 parquetmake -C cpp/build-release -j8 parquet_sharedmake -C cpp/build-release -j8 parquet-benchmarksbenchmark/1.9.4Benchmark
Release, ZSTD, three repetitions, 4 MiB float payload per benchmark case:
The detailed matrix and larger Hardwood-sized stress results are in
parquet_vector_reader_optimization.md.