Skip to content

GH-51041: [Python] Reject non-Buffer FunctionOptions.deserialize input #51129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1fanwang wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

GH-51041: [Python] Reject non-Buffer FunctionOptions.deserialize input #51129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/pyarrow/_compute.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@ cdef class FunctionOptions(_Weakrefable):
return pyarrow_wrap_buffer(c_buf)

@staticmethod
def deserialize(buf):
def deserialize(Buffer buf not None):
"""
Deserialize options for a function.

Expand Down
6 changes: 6 additions & 0 deletions python/pyarrow/tests/test_compute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,12 @@ def test_option_class_equality(request):
"ArraySortOptions(order=Ascending, null_placement=AtEnd)"


@pytest.mark.parametrize("value", [None, 1, [], b""])
def test_function_options_deserialize_rejects_non_buffers(value):
with pytest.raises(TypeError):
pc.FunctionOptions.deserialize(value)


def test_list_functions():
assert len(pc.list_functions()) > 10
assert "add" in pc.list_functions()
Expand Down