GH-50471: [C++][Python] Bump bundled mimalloc to 3.4.1#50555
Closed
raulcd wants to merge 6 commits into
Closed
Conversation
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the bundled mimalloc version used by Arrow’s C++ (and thus Python wheel) builds to address a known multi-threaded initialization crash scenario.
Changes:
- Bump
ARROW_MIMALLOC_BUILD_VERSIONfromv3.3.1tov3.4.1. - Update the corresponding SHA256 checksum for the mimalloc source archive.
Member
Author
|
Unfortunately the two failures are suspicious and look related. Those seeming to affect only macOS arm64 doesn't make it easy to debug/diagnose. |
Comment on lines
2569
to
+2573
| -DMI_INSTALL_TOPLEVEL=ON | ||
| # Don't override default malloc | ||
| -DMI_OVERRIDE=OFF | ||
| -DMI_OSX_INTERPOSE=OFF | ||
| -DMI_OSX_ZONE=OFF |
Member
Author
|
I'll close this PR as there's a second PR from @pitrou that is covering similar problems. Both the initial fix on that PR and the bump seem required to be done together: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
A new version of mimalloc was released. The existing version of mimalloc can cause a segmentation fault as seen on the referenced issue.
What changes are included in this PR?
Bumping the mimalloc version.
Are these changes tested?
Yes, via CI and archery.
I've also tested the minimal reproducer from the issue:
The above cause a segfault on every execution with pyarrow 25.0.0 on a local Python 3.14. With the new built wheel with the new mimalloc version, I haven't been able to reproduce the segfault after several attempts.
Are there any user-facing changes?
No