Skip to content

GH-50098: [C++][Parquet] Enable filesystem support when building Parquet utilities #50099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pitrou wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −4
Open

GH-50098: [C++][Parquet] Enable filesystem support when building Parquet utilities #50099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions cpp/cmake_modules/DefineOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,11 +582,12 @@ takes precedence over ccache if a storage backend is configured" ON)
set_option_category("Parquet")

define_option(PARQUET_BUILD_EXECUTABLES
"Build the Parquet executable CLI tools. Requires static libraries to be built."
Copy link
Copy Markdown
Member Author

@pitrou pitrou Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked that static libraries are not required for the Parquet executables to work, so removing the misleading statement.

OFF)
"Build the Parquet executable CLI tools."
OFF
DEPENDS
ARROW_FILESYSTEM)

define_option(PARQUET_BUILD_EXAMPLES
"Build the Parquet examples. Requires static libraries to be built." OFF)
define_option(PARQUET_BUILD_EXAMPLES "Build the Parquet examples." OFF)

define_option(PARQUET_REQUIRE_ENCRYPTION
"Build support for encryption. Fail if OpenSSL is not found"
Expand Down
6 changes: 6 additions & 0 deletions cpp/src/arrow/compute/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ set(ARROW_COMPUTE_TEST_ARGS PREFIX ${ARROW_COMPUTE_TEST_PREFIX} LABELS
# Also see: GH-34388, GH-34615
function(ADD_ARROW_COMPUTE_TEST REL_TEST_NAME)
if(NOT ARROW_COMPUTE)
# libarrow_compute is not enabled, skip building test
return()
endif()

Expand Down Expand Up @@ -109,6 +110,11 @@ endfunction()
# part of libarrow.
# It will also link the compute libraries to the benchmark target.
function(add_arrow_compute_benchmark REL_TEST_NAME)
if(NOT ARROW_COMPUTE)
# libarrow_compute is not enabled, skip building benchmark
return()
endif()

set(options)
set(one_value_args PREFIX)
set(multi_value_args EXTRA_SOURCES EXTRA_LINK_LIBS)
Expand Down
Loading