Skip to content

GH-49684: [MATLAB] Introduce deprecation warnings for "legacy" Feather V1 functions featherread and featherwrite #49705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevingurney wants to merge 4 commits into
base: main
Choose a base branch
from
+45 −0
Open

GH-49684: [MATLAB] Introduce deprecation warnings for "legacy" Feather V1 functions featherread and featherwrite #49705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1dfb18
Add Feather V1 deprecation warning to `featherwrite.m`.
Apr 8, 2026
1d139dd
Add Feather V1 deprecation warning to `featherread.m`.
Apr 8, 2026
e9c2825
Suppress Feather V1 warnings in Feather tests.
Apr 9, 2026
d0a9e88
Add test cases to verify Feather V1 deprecation warnings.
Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions matlab/src/matlab/featherread.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@
filename(1, 1) string {mustBeNonmissing, mustBeNonzeroLengthText}
end

warning("arrow:io:feather:v1:FeatherReadDeprecated", ...
"Reading from Feather V1 files is deprecated. Use arrow.io.ipc.RecordBatchFileReader to read from Feather V2 (Arrow IPC) files.");


typesToCast = [arrow.type.ID.UInt8, ...
arrow.type.ID.UInt16, ...
arrow.type.ID.UInt32, ...
Expand Down
3 changes: 3 additions & 0 deletions matlab/src/matlab/featherwrite.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ function featherwrite(filename, t)
t table
end

warning("arrow:io:feather:v1:FeatherWriteDeprecated", ...
"Writing to Feather V1 files is deprecated. Use arrow.io.ipc.RecordBatchFileWriter to write to Feather V2 (Arrow IPC) files.");

recordBatch = arrow.recordBatch(t);
writer = arrow.internal.io.feather.Writer(filename);
writer.write(recordBatch);
Expand Down
9 changes: 9 additions & 0 deletions matlab/test/arrow/io/feather/tRoundTrip.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,15 @@
% permissions and limitations under the License.
classdef tRoundTrip < matlab.unittest.TestCase

methods(TestMethodSetup)

function suppressFeatherV1Warnings(testCase)
import matlab.unittest.fixtures.SuppressedWarningsFixture
testCase.applyFixture(SuppressedWarningsFixture("arrow:io:feather:v1:FeatherReadDeprecated"));
end

end

methods(Test)
function Basic(testCase)
import matlab.unittest.fixtures.TemporaryFolderFixture
Expand Down
29 changes: 29 additions & 0 deletions matlab/test/tfeather.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ function setupTempWorkingDirectory(testCase)
import matlab.unittest.fixtures.WorkingFolderFixture;
testCase.applyFixture(WorkingFolderFixture);
end

function suppressFeatherV1Warnings(testCase)
import matlab.unittest.fixtures.SuppressedWarningsFixture
testCase.applyFixture(SuppressedWarningsFixture("arrow:io:feather:v1:FeatherReadDeprecated"));
testCase.applyFixture(SuppressedWarningsFixture("arrow:io:feather:v1:FeatherWriteDeprecated"));
end

end

Expand Down Expand Up @@ -267,6 +273,29 @@ function UnicodeVariableNames(testCase)
testCase.verifyEqual(actualTable, expectedTable);
end

function VerifyFeatherReadDeprecationWarning(testCase)
filename = fullfile(pwd, 'temp.feather');

t = array2table([1, 2, 3]);
featherwrite(filename, t);

warning("on", "arrow:io:feather:v1:FeatherReadDeprecated");
fcn = @() featherread(filename);
testCase.verifyWarning(fcn, "arrow:io:feather:v1:FeatherReadDeprecated")
warning("off", "arrow:io:feather:v1:FeatherReadDeprecated");
end

function VerifyFeatherWriteDeprecationWarning(testCase)
filename = fullfile(pwd, 'temp.feather');

t = array2table([1, 2, 3]);

warning("on", "arrow:io:feather:v1:FeatherWriteDeprecated");
fcn = @() featherwrite(filename, t);
testCase.verifyWarning(fcn, "arrow:io:feather:v1:FeatherWriteDeprecated")
warning("off", "arrow:io:feather:v1:FeatherReadDeprecated");
end

end
end

Expand Down
Loading