GH-49302: [Python][Doc] Incorrect parameter descriptions in SparseCSCMatrix.from_numpy#49303
Open
chilin0525 wants to merge 1 commit intoapache:mainfrom
Open
GH-49302: [Python][Doc] Incorrect parameter descriptions in SparseCSCMatrix.from_numpy#49303chilin0525 wants to merge 1 commit intoapache:mainfrom
chilin0525 wants to merge 1 commit intoapache:mainfrom
Conversation
Signed-off-by: ChiLin Chiu <chilin.chiou@gmail.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The docstring for
SparseCSCMatrix.from_numpyinpython/pyarrow/tensor.pxihas incorrect parameter descriptions:arrow/python/pyarrow/tensor.pxi
Lines 978 to 995 in 1114958
indptris described as "Range of the rows" but should be "Range of the columns"indicesis described as "Column indices" but should be "Row indices"What changes are included in this PR?
Fix parameter descriptions in SparseCSCMatrix.from_numpy in python/pyarrow/tensor.pxi:
Are these changes tested?
Yes.
Are there any user-facing changes?
No.