GH-49237: [R] Deprecate Feather reader and writer#49276
Draft
thisisnic wants to merge 2 commits intoapache:mainfrom
Draft
GH-49237: [R] Deprecate Feather reader and writer#49276thisisnic wants to merge 2 commits intoapache:mainfrom
thisisnic wants to merge 2 commits intoapache:mainfrom
Conversation
|
|
d3eca24 to
d32a2e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Arrow C++ is deprecating the Feather reader/writer (#49231) so we should update the R functions too
What changes are included in this PR?
write_featherto mention in the docs that it's deprecated.write_feather()to wrap new functionwrite_ipc_impl()so we can show deprecation warnings on calls towrite_feather()only (previouslywrite_ipc_file()calledwrite_feather()and so I didn't wanna add the deprecation warning without this refactor otherwise a call towrite_ipc_file()would trigger it erroneously)write_feather()we can remove this extra functionread_ipc_file()andread_feather()into separate functions so we can document them differently. Updated the examples to show usingread_ipc_file()Some 🤖 use here, but I decided on what to do.
Are these changes tested?
Yep
Are there any user-facing changes?
Yep - deprecation warning