Skip to content

[C++] HasVariadicBuffers should respect extension types #54924

Closed

Description

@taepper

Describe the bug, including details regarding any error messages, version, and platform.

The current implementation of bool ArraySpan::HasVariadicBuffers does not handle extension types properly and always reports false.

::SetMembers however does handle these explicitly and we should handle extension types in the HasVariadicBuffers implementation similarly:

Type::type type_id = this->type->id();
  if (type_id == Type::EXTENSION) {
    auto* ext_type = checked_cast<const ExtensionType*>(this->type);
    type_id = ext_type->storage_type()->id();
  }

Component(s)

C++

Activity

  1. changed the title [-]`HasVariadicBuffers` should respect extension types[/-] [+][C++] `HasVariadicBuffers` should respect extension types[/+] on Oct 22, 2026
  2. added this to the 27.0.0 milestone on Oct 26, 2026
  3. pitrou commented on Oct 26, 2026

    @pitrou
    Member

    Issue resolved by pull request 54925
    #54925

  4. added a commit that references this issue on Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions