Repository navigation
GH-551: [Java] Add TimeStamp*TZ support to ComplexCopier - #1414
Open
henriquejsza wants to merge 1 commit into
Open
henriquejsza wants to merge 1 commit into
henriquejsza wants to merge 1 commit into
Conversation
ComplexCopier skipped every minor type that has type parameters except Decimal, so copying a vector containing TimeStampSecTZ, TimeStampMilliTZ, TimeStampMicroTZ, or TimeStampNanoTZ threw UnsupportedOperationException. Generate the copy and writer-lookup cases for the timezone-aware timestamp types the same way as the other scalar types, and pass the timezone through to the struct writer so it is preserved. Add list, struct and map copy tests for TimeStampNanoTZ. Closes apache#551. Signed-off-by: henriquejsza <henriquejsza@gmail.com>
henriquejsza
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
October 30, 2026 15:39
|
Thank you for opening a pull request! Please label the PR with one or more of:
Also, add the 'breaking-change' label if appropriate. See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
ComplexCopierskipped every minor type that has type parameters exceptDecimal, so copying a vector containingTimeStampSecTZ,TimeStampMilliTZ,TimeStampMicroTZ, orTimeStampNanoTZthrewUnsupportedOperationException.This generates the copy and writer-lookup cases for the timezone-aware
timestamp types the same way as the other scalar types, and passes the
timezone through to the struct writer so it is preserved. The fix is in the
FreeMarker template
vector/src/main/codegen/templates/ComplexCopier.java;the generated
ComplexCopieris produced from it.Added list, struct, and map copy tests for
TimeStampNanoTZ.Closes #551.