Skip to content

chore: Add pull request template#100

Merged
kou merged 2 commits into
apache:mainfrom
Benjamin-Philip:bp/pr-template
Jul 9, 2026
Merged

chore: Add pull request template#100
kou merged 2 commits into
apache:mainfrom
Benjamin-Philip:bp/pr-template

Conversation

@Benjamin-Philip

Copy link
Copy Markdown
Collaborator

What issue does this PR close?

Doesn't close an issue in the tracker. PR messages should match the structure of
commits in this repo and other arrow projects.

What's Changed

Adds a PR template for better consistency. Based on apache/arrow-swift#19 and https://github.com/apache/arrow-js/blob/main/.github/pull_request_template.md.

Copilot AI review requested due to automatic review settings July 8, 2026 15:35
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Preview URL: https://Benjamin-Philip.github.io/arrow-erlang-1

If the preview URL doesn't work, you may have forgotten to configure your fork repository for preview.
See https://github.com/apache/arrow-erlang/blob/main/CONTRIBUTING.md#forks for instructions on how to configure.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a repository-level pull request template to standardize PR bodies and better align them with the project’s contribution guidance and other Arrow subprojects.

Changes:

  • Introduces .github/pull_request_template.md with an ASF license header and standard PR sections.
  • Adds prompts for issue linkage, change description, and breaking-change signaling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +20 to +22
## What issue does this PR close?

Closes #NNN.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most PRs will close a tracked issue, so I think it's fine as-is.


Please fill in a description of the changes here.

**This contains breaking changes.** <- Remove this line if there are no breaking changes.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Embarrassing noisy placeholder text is more likely to be read than a checkbox. If it remains, it's probably a signal that the PR author isn't reviewing their code properly.

(Fingers crossed that I don't let this split through in a future PR).

@Benjamin-Philip Benjamin-Philip requested a review from kou July 8, 2026 16:05

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment thread .github/pull_request_template.md Outdated
Copilot AI review requested due to automatic review settings July 9, 2026 00:45
@kou kou merged commit b42fa40 into apache:main Jul 9, 2026
9 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@Benjamin-Philip Benjamin-Philip deleted the bp/pr-template branch July 9, 2026 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants