Repository navigation
feat(csharp): support typed options in connection profiles - #4914
Open
CurtHagenlocher wants to merge 1 commit into
Open
CurtHagenlocher wants to merge 1 commit into
CurtHagenlocher wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues; the opt-in APIs preserve compatibility and have focused regression coverage.
0 open findings
What changed in this PR
Adds opt-in typed connection-profile options to the C# driver manager while preserving existing string-based behavior for compatibility.
Changes:
- Adds typed option merging and database-opening APIs.
- Documents compatibility constraints and adds tests for type preservation, overrides, and validation.
| File | Description |
|---|---|
| csharp/test/Apache.Arrow.Adbc.Tests/DriverManager/TomlConnectionProfileTests.cs | Tests typed options and string-based compatibility. |
| csharp/test/Apache.Arrow.Adbc.Tests/DriverManager/FakeAdbcDriver.cs | Adds a typed-option test driver and database. |
| csharp/src/Apache.Arrow.Adbc/DriverManager/AdbcDriverManager.cs | Adds and documents opt-in typed profile APIs. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
@davidhcoe, you've thought more about the driver manager than I have; please take a look. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for typed options in connection profiles. This diverges from the C implementation for backwards compatibility. Otherwise, a profile like
would fail in
AdbcDatabaseInit. See #4913.Relates to #4751