Repository navigation
fix(csharp): match the driver manager spec for entry point name - #4912
Open
CurtHagenlocher wants to merge 1 commit into
Open
CurtHagenlocher wants to merge 1 commit into
CurtHagenlocher wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation has regression coverage and no identified blocking issues.
0 open findings
What changed in this PR
Aligns C# driver entrypoint derivation with other ADBC driver managers, addressing the naming inconsistency discussed in #4751.
Changes:
- Updates filename normalization and symbol construction while preserving internal capitalization.
- Adds regression cases for versioned libraries, cross-platform paths, and alternative driver names.
| File | Description |
|---|---|
| csharp/test/Apache.Arrow.Adbc.Tests/DriverManager/TomlConnectionProfileTests.cs | Expands entrypoint naming regression coverage. |
| csharp/src/Apache.Arrow.Adbc/DriverManager/AdbcDriverManager.cs | Updates derivation rules and documentation; removes the obsolete helper. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
@davidhcoe, you've thought more about the driver manager than I have; please take a look. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #4751