Repository navigation
Conversation
kou
reviewed
Oct 15, 2026
Comment on lines
+50
to
+58
| ARG TARGETPLATFORM | ||
| RUN if [[ ${TARGETPLATFORM} == "linux/amd64" ]]; then \ | ||
| ARCH="amd64"; \ | ||
| elif [[ ${TARGETPLATFORM} == "linux/arm64" ]]; then \ | ||
| ARCH="arm64"; \ | ||
| else \ | ||
| echo "Unsupported platform: ${TARGETPLATFORM}"; \ | ||
| exit 1; \ | ||
| fi && \ |
Member
There was a problem hiding this comment.
Can we use arch or something instead of adding a new build argument?
Author
There was a problem hiding this comment.
I replaced it with arch. TARGETPLATFORM is just a build arg docker populates.
Comment on lines
+397
to
+409
| target: | ||
| - almalinux-8 | ||
| - almalinux-9 | ||
| - almalinux-10 | ||
| - debian-trixie | ||
| - ubuntu-jammy | ||
| - ubuntu-noble | ||
| include: | ||
| - { target: almalinux-8, runner: ubuntu-latest } | ||
| - { target: almalinux-8-aarch64, runner: ubuntu-24.04-arm } | ||
| - { target: almalinux-9, runner: ubuntu-latest } | ||
| - { target: almalinux-9-aarch64, runner: ubuntu-24.04-arm } | ||
| - { target: almalinux-10, runner: ubuntu-latest } | ||
| - { target: almalinux-10-aarch64, runner: ubuntu-24.04-arm } | ||
| - { target: debian-trixie, runner: ubuntu-latest } | ||
| - { target: debian-trixie-arm64, runner: ubuntu-24.04-arm } | ||
| - { target: ubuntu-jammy, runner: ubuntu-latest } | ||
| - { target: ubuntu-jammy-arm64, runner: ubuntu-24.04-arm } | ||
| - { target: ubuntu-noble, runner: ubuntu-latest } | ||
| - { target: ubuntu-noble-arm64, runner: ubuntu-24.04-arm } |
Member
There was a problem hiding this comment.
Can we define only the distribution part such as almalinux-8 and the architecture part such as arm64 and compute target and runner from them? For example:
linux:
name: Linux ${{ matrix.distribution }} ${{ matrix.architecture }}
runs-on: ${{ matrix.architecture == 'arm64' && 'ubuntu-24.04-arm' || 'ubuntu-latest' }}
needs:
- source
strategy:
fail-fast: false
matrix:
distribution:
- almalinux-8
- almalinux-9
- almalinux-10
- debian-trixie
- ubuntu-jammy
- ubuntu-noble
architecture:
- amd64
- arm64
env:
# amd64: almalinux-10, debian-trixie, ...
# arm64: almalinux-10-aarch64, debian-trixie-arm64, ...
TARGET: >-
${{ matrix.distribution }}${{
matrix.architecture == 'arm64' &&
(startsWith(matrix.distribution, 'almalinux-') && '-aarch64' || '-arm64') ||
''
}}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add arm64 build to all current linux package targets.
Replaces #3004
Closes #4898