Repository navigation
fix(rust/ffi)!: importing partitions is unsafe - #4876
Merged
Merged
Conversation
We can't validate that the pointers and such are valid, so we shouldn't make the conversion safe - instead it must be unsafe. Assisted-by: GPT-6.1 Sol
lidavidm
force-pushed
the
rs-partition-import
branch
from
October 9, 2026 01:16
df46a30 to
ef89140
Compare
lidavidm
marked this pull request as ready for review
October 9, 2026 01:54
eitsupi
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't validate that the pointers and such are valid, so we shouldn't make the conversion safe - instead it must be unsafe.
Assisted-by: GPT-6.1 Sol