Repository navigation
fix(rust/ffi)!: require Send for exported types - #4874
Merged
Merged
Conversation
This matches the specification in the C header: handles aren't necessarily usable concurrently, but they can be used from different threads so long as access does not overlap. Assisted-by: GPT-6.1 Sol
There was a problem hiding this comment.
🟢 Approval recommended
The bounds correctly enforce serialized cross-thread handle movement without requiring concurrent access.
0 open findings
What changed in this PR
Requires Rust-exported ADBC handles to be safely movable between threads, matching the C API contract.
Changes:
- Adds
Sendbounds for database, connection, and statement types. - Documents the new export requirement.
| File | Description |
|---|---|
rust/ffi/src/driver_exporter.rs |
Enforces and documents Send for exported handle types. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Mandukhai-Alimaa
approved these changes
Oct 8, 2026
eitsupi
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the specification in the C header: handles aren't necessarily usable concurrently, but they can be used from different threads so long as access does not overlap.
Assisted-by: GPT-6.1 Sol