Repository navigation
fix(rust/ffi): clear release callback on partitions after release - #4873
Merged
Merged
Conversation
Assisted-by: GPT-6.1 Sol
There was a problem hiding this comment.
🟢 Approval recommended
The release lifecycle is safely guarded and adequately tested.
0 open findings
What changed in this PR
Ensures Rust FFI partitions cannot be deallocated repeatedly.
Changes:
- Clears the release callback before deallocation.
- Nulls released fields and adds lifecycle tests.
| File | Description |
|---|---|
rust/ffi/src/types.rs |
Makes partition release idempotent and tests cleanup behavior. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Mandukhai-Alimaa
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: GPT-6.1 Sol