Repository navigation
build(c/driver/sqlite): work around macOS modifications to sqlite - #4860
Merged
Merged
Conversation
Trimmed example of errors: ``` c/driver/sqlite/sqlite.cc:760:50: error: 'sqlite3_txn_state' is only available on macOS 12.0 or newer [-Werror,-Wunguarded-availability-new] /usr/include/sqlite3.h:6947:16: note: 'sqlite3_txn_state' has been marked as being introduced in macOS 12.0 here, but the deployment target is macOS 10.15.0 c/driver/sqlite/sqlite.cc:760:50: note: enclose 'sqlite3_txn_state' in a __builtin_available check to silence this warning c/driver/sqlite/sqlite.cc:1168:43: error: 'sqlite3_total_changes64' is only available on macOS 12.3 or newer [-Werror,-Wunguarded-availability-new] /usr/include/sqlite3.h:2870:26: note: 'sqlite3_total_changes64' has been marked as being introduced in macOS 12.3 here, but the deployment target is macOS 10.15.0 /Users/runner/work/arrow-adbc/arrow-adbc/c/driver/sqlite/sqlite.cc:1168:43: note: enclose 'sqlite3_total_changes64' in a __builtin_available check to silence this warning ```
lidavidm
marked this pull request as ready for review
October 6, 2026 05:14
lidavidm
requested review from
Mandukhai-Alimaa
and
a balanced review from Copilot
October 6, 2026 05:14
Member
Author
|
Passing JavaScript build: https://github.com/lidavidm/arrow-adbc/actions/runs/37425115917 |
Mandukhai-Alimaa
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trimmed example of errors: