fix(java/driver/jni): harden JNI exception helpers#4395
Open
lidavidm wants to merge 1 commit into
Open
Conversation
Replace assert() guards in both ThrowJavaException helpers with proper null checks that return early when JNI calls fail. Also fix malformed JNI method descriptor in ThrowJavaException. When any JNI lookup fails, it leaves a pending exception, so returning early propagates the correct error back to Java. Assisted-by: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR hardens the Java JNI driver’s exception-throwing helpers by replacing assert()-based guards (which can be compiled out in release builds) with explicit null checks, and it fixes an invalid JNI constructor method descriptor for Java exceptions.
Changes:
- Replace
assert(...)checks in bothThrowJavaExceptionhelpers with early-return null checks forFindClass,GetMethodID,NewStringUTF, andNewObject. - Fix the malformed JNI method descriptor for the
(String)constructor from(Ljava/lang/String)Vto(Ljava/lang/String;)V. - Add an explicit null check for the resolved
AdbcStatusCodestatic field ID before attempting to fetch it.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace assert() guards in both ThrowJavaException helpers with proper null checks that return early when JNI calls fail. Also fix malformed JNI method descriptor in ThrowJavaException.
Assisted-by: Claude Opus 4.8 noreply@anthropic.com