test(core): cover the variadic form of response.exit and response.say - #13771
Open
AlinsRan wants to merge 1 commit into
Open
test(core): cover the variadic form of response.exit and response.say#13771AlinsRan wants to merge 1 commit into
AlinsRan wants to merge 1 commit into
Conversation
response.t only exercised exit(code, body). The variadic form that resp_exit actually implements -- a non-numeric first argument, and several body parts in one call -- had no coverage, nor did say(). Signed-off-by: AlinsRan <alinsran@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resp_exitis variadic — it accepts a non-numeric first argument (no status code), and any number of body parts which are printed in order, with tables encoded as JSON:t/core/response.tonly ever callsexit(code, body), so none of that is covered, and_M.sayis not exercised at all.apisix/plugins/mcp/server_wrapper.luaalready depends on the variadic form:Changes
Three tests, no production code touched:
exit("done\n"): no status code, body still written, response stays 200exit(201, "a", {b = "b"}, "c\n"): parts printed in order, the table encoded as JSONsay("a", "b", "c\n")Checklist