fix(healthcheck): use immediate clear() to ensure k8s endpoint change…#13029
Open
tyq010101 wants to merge 1 commit intoapache:masterfrom
Open
fix(healthcheck): use immediate clear() to ensure k8s endpoint change…#13029tyq010101 wants to merge 1 commit intoapache:masterfrom
tyq010101 wants to merge 1 commit intoapache:masterfrom
Conversation
dosubot
bot
added
size:S
…s take effect Replace delayed_clear() with immediate clear() in healthcheck_manager to fix an issue where k8s endpoint changes would not take effect immediately. The delayed clear could cause healthcheck to continue using stale IP addresses after endpoint updates. Old K8s Endpoint ip has destroyed, but healthCheck manager always check old ip address
tyq010101
force-pushed
the
fix/k8s_ipaddress_no_update
branch
from
03b48d9 to
3af6251
Compare
Author
|
#12803 |
Contributor
|
The current method of clearing all data causes a temporary loss of health status with each upstream configuration update. The correct approach is to precisely remove nodes that no longer exist in the new upstream configuration. This clears the old stale IPs while preserving the historical health status of unchanged nodes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s take effect
Replace delayed_clear() with immediate clear() in healthcheck_manager to fix an issue where k8s endpoint changes would not take effect immediately. The delayed clear could cause healthcheck to continue using stale IP addresses after endpoint updates.
Description
Which issue(s) this PR fixes:
Fixes #
Checklist