Skip to content

Conversation

@kayx23
Copy link
Member

@kayx23 kayx23 commented Jan 29, 2026

This comment was marked as resolved.

@kayx23
Copy link
Member Author

kayx23 commented Jan 30, 2026

About 1fc6686: It's not all loggers as the PR title states - just the access log plugins.

@kayx23
Copy link
Member Author

kayx23 commented Jan 30, 2026

About 3b188a1: from the PR code changes, it looks like both access and error logs will log the request ID variable (even when request-id plugin is not enabled).

  • Plugin disabled: use nginx's built-in $request_id
  • Plugin enabled: use UUID from the request-id plugin

The PR description and title were a bit misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants