Skip to content

UI: Keep Grid run tooltips inside the viewport #72161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NihalRadhakrishna wants to merge 1 commit into
base: main
Choose a base branch
from
+80 −62
Open

UI: Keep Grid run tooltips inside the viewport #72161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions airflow-core/src/airflow/ui/src/layouts/Details/Grid/GridButton.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import { Wrapper } from "src/utils/Wrapper";
import { GridButton } from "./GridButton";

describe("GridButton", () => {
it("shows run details in the grid tooltip respecting the selected timezone", () => {
it("shows run details in the grid tooltip respecting the selected timezone", async () => {
vi.useFakeTimers();

render(
Expand All @@ -45,17 +45,19 @@ describe("GridButton", () => {
{ wrapper: Wrapper },
);

act(() => {
fireEvent.mouseEnter(screen.getByText("bar"));
vi.advanceTimersByTime(500);
});
try {
await act(async () => {
fireEvent.pointerEnter(screen.getByText("bar"));
await vi.advanceTimersByTimeAsync(500);
});

expect(screen.getByTestId("basic-tooltip")).toHaveTextContent("2026-04-21 02:00:00");
expect(screen.getByTestId("basic-tooltip")).toHaveTextContent(
"common:runId: manual__2026-04-21T00:00:00+00:00",
);
expect(screen.getByTestId("basic-tooltip")).toHaveTextContent("duration: 01:01:01");
const tooltip = screen.getByRole("tooltip");

vi.useRealTimers();
expect(tooltip).toHaveTextContent("2026-04-21 02:00:00");
expect(tooltip).toHaveTextContent("common:runId: manual__2026-04-21T00:00:00+00:00");
expect(tooltip).toHaveTextContent("duration: 01:01:01");
} finally {
vi.useRealTimers();
}
});
});
118 changes: 67 additions & 51 deletions airflow-core/src/airflow/ui/src/layouts/Details/Grid/GridButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@
* specific language governing permissions and limitations
* under the License.
*/
import { Flex, type FlexProps } from "@chakra-ui/react";
import { Box, Flex, type FlexProps, Text, VStack } from "@chakra-ui/react";
import { useTranslation } from "react-i18next";
import { Link } from "react-router-dom";

import type { DagRunState, TaskInstanceState } from "openapi/requests/types.gen";
import { BasicTooltip } from "src/components/BasicTooltip";
import Time from "src/components/Time";
import { Tooltip } from "src/components/ui";
import { renderDuration } from "src/utils/datetimeUtils";

type Props = {
Expand Down Expand Up @@ -50,54 +50,70 @@ export const GridButton = ({
}: Props) => {
const { t: translate } = useTranslation();

const tooltipContent = (
<>
<Time datetime={runAfter} />
<br />
{translate("common:runId")}: {runId}
<br />
{translate("state")}:{" "}
{state ? translate(`common:states.${state}`) : translate("common:states.no_status")}
<br />
{translate("duration")}: {renderDuration(duration)}
</>
);

return isGroup ? (
<BasicTooltip content={tooltipContent}>
<Flex
background={`${state}.solid`}
borderRadius={2}
height="10px"
minW="14px"
pb="2px"
px="2px"
{...rest}
>
{children}
</Flex>
</BasicTooltip>
) : (
<BasicTooltip content={tooltipContent}>
<Link
replace
to={{
pathname: `/dags/${dagId}/runs/${runId}/${taskId === undefined ? "" : `tasks/${taskId}`}`,
search: searchParams.toString(),
}}
>
<Flex
background={`${state}.solid`}
borderRadius={2}
height="10px"
pb="2px"
px="2px"
width="14px"
{...rest}
>
{children}
</Flex>
</Link>
</BasicTooltip>
return (
<Tooltip
content={
<VStack align="start" gap={1}>
<Text>
<Time datetime={runAfter} />
</Text>
<Text>
{translate("common:runId")}: {runId}
</Text>
<Text>
{translate("state")}:{" "}
{state ? translate(`common:states.${state}`) : translate("common:states.no_status")}
</Text>
<Text>
{translate("duration")}: {renderDuration(duration)}
</Text>
</VStack>
}
openDelay={500}
portalled
positioning={{
offset: {
crossAxis: 5,
mainAxis: 5,
},
placement: "bottom",
}}
>
<Box as="span" display="inline-block">
{isGroup ? (
<Flex
background={`${state}.solid`}
borderRadius={2}
height="10px"
minW="14px"
pb="2px"
px="2px"
{...rest}
>
{children}
</Flex>
) : (
<Link
replace
to={{
pathname: `/dags/${dagId}/runs/${runId}/${taskId === undefined ? "" : `tasks/${taskId}`}`,
search: searchParams.toString(),
}}
>
<Flex
background={`${state}.solid`}
borderRadius={2}
height="10px"
pb="2px"
px="2px"
width="14px"
{...rest}
>
{children}
</Flex>
</Link>
)}
</Box>
</Tooltip>
);
};