Skip to content

Support assigned reviewers in LLM approval reviews - #72157

Draft
guan404ming wants to merge 1 commit into
apache:mainfrom
guan404ming:llm-approval-assigned-users
Draft

Support assigned reviewers in LLM approval reviews#72157
guan404ming wants to merge 1 commit into
apache:mainfrom
guan404ming:llm-approval-assigned-users

Conversation

@guan404ming

Copy link
Copy Markdown
Member

Why

  • An LLM approval review was open to every user with the HITL permission.
  • There was no way to route a decision to the people who actually own it.

How

  • Add approval_assigned_users to name the reviewers allowed to answer.
  • Forward those users to the review request, as HITLOperator already does.
  • Reject the parameter on cores older than Airflow 3.2, which cannot store it.

Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines

@guan404ming
guan404ming force-pushed the llm-approval-assigned-users branch from b63e1b0 to 8e8b27c Compare August 27, 2026 15:10
@guan404ming guan404ming changed the title Restrict LLM approval reviews to assigned users Support assigned reviewers in LLM approval reviews Aug 27, 2026
The review was always open to every user with the HITL permission, so an
operator could not route an approval to the people who actually own the
decision. The Task SDK already accepts assigned users for a review; the
LLM operators simply never passed any.
@guan404ming
guan404ming force-pushed the llm-approval-assigned-users branch from 8e8b27c to 3030164 Compare August 27, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant