Support timeout defaults in LLM approval reviews - #72155
Open
guan404ming wants to merge 1 commit into
Open
Conversation
guan404ming
force-pushed
the
llm-approval-timeout-default
branch
from
August 27, 2026 14:11
cba52aa to
3f6cd0f
Compare
guan404ming
changed the title
The approval review always passed no HITL defaults, so approval_timeout could only ever fail the task. An unattended pipeline had no way to say "nobody reviewed this in time, treat it as approved" (or rejected), which is what a deadline on a review is usually for.
guan404ming
force-pushed
the
llm-approval-timeout-default
branch
from
August 27, 2026 14:12
3f6cd0f to
c2d0b1c
Compare
guan404ming
changed the title
guan404ming
marked this pull request as ready for review
August 27, 2026 14:24
guan404ming
requested review from
Lee-W,
ashb,
gopidesupavan and
kaxil
as code owners
August 27, 2026 14:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
How
on_approval_timeoutto choose fail, approve, or reject on deadline.approval_timeoutis configured.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines