Fix unscheduled tasks left on a stale Dag version - #72153
Draft
FrankYang0529 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
state = Nonecan be updated to the latest Dag version when the Dag changed. The code was a Python loop over the run's task instances andNone in State.unfinishedisTrue.UPDATE ... WHERE state IN (...)so the scheduler no longer loads every task instance into memory.State.unfinishedstill containsNone, but SQLINdoesn't matchNULL. The scheduler cannot update the task instances to the latest Dag version that have not been scheduled yet.How
or_(TI.state.is_(None), TI.state.in_(State.unfinished)).Verification
uv run --project airflow-core pytest airflow-core/tests/unit/jobs/test_scheduler_job.py -qWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.