Skip to content

Respect the limit search param in the task overview duration chart - #72147

Open
warreee wants to merge 1 commit into
apache:mainfrom
warreee:fix-task-overview-duration-chart-limit
Open

Respect the limit search param in the task overview duration chart#72147
warreee wants to merge 1 commit into
apache:mainfrom
warreee:fix-task-overview-duration-chart-limit

Conversation

@warreee

@warreee warreee commented Aug 27, 2026

Copy link
Copy Markdown

The duration chart on the task overview always requested the last 14 task instances, ignoring the number of dag runs the user picked. The dag details layout already writes that choice to the limit search param, and the dag overview page reads a value of its own, so the task page was the only view that could not be widened.

Read the same limit search param the details layout writes, falling back to the same default of 10, so the chart follows the selector and can be shared through the URL.

The remaining limit on the failed task instance query is left alone: that query only reads total_entries and never renders the rows it fetches.

Before:
Screenshot 2026-08-27 at 13 43 53

After:
Screenshot 2026-08-27 at 13 39 14


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Helped-by: [Claude] following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

The duration chart on the task overview always requested the last 14 task
instances, ignoring the number of dag runs the user picked. The dag details
layout already writes that choice to the limit search param, and the dag
overview page reads a value of its own, so the task page was the only view
that could not be widened.

Read the same limit search param the details layout writes, falling back to
the same default of 10, so the chart follows the selector and can be shared
through the URL.

The remaining limit on the failed task instance query is left alone: that
query only reads total_entries and never renders the rows it fetches.
@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Aug 27, 2026
@boring-cyborg

boring-cyborg Bot commented Aug 27, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant