Fix airflow config get-value silently succeeding on a missing option - #72145
Open
Eason09053360 wants to merge 1 commit into
Open
Fix airflow config get-value silently succeeding on a missing option#72145Eason09053360 wants to merge 1 commit into
Eason09053360 wants to merge 1 commit into
Conversation
`airflow config get-value` swallowed the lookup failure and exited 0 with nothing on stdout, so a script capturing its output could not tell a missing option from an empty one. The parser's "not found" warning also landed on stdout, corrupting the one stream the command exists to produce. The exception was swallowed in the first place to avoid the double deprecation warning that a has_option() pre-check triggered (apache#40319). That constraint still holds, and so does the need to let a genuine lookup failure -- a failed *_cmd, an unreachable secrets backend -- reach the user with its own message rather than being reported as a missing option.
Eason09053360
requested review from
bugraoz93,
dheerajturaga,
henry3260 and
potiuk
as code owners
August 27, 2026 10:59
Member
|
First of all This is user facing change so newsfragment should be added explaining the behaviour change (which otherwise makes sense). But more importantly - you need to make a wider chaeck in all similar methods and see what behaviour is there - and raise this change proposal to devlist, describing a general change in the interface ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
airflow config get-valueexited 0 with nothing on stdout when the option did not exist, so a script capturing its output could not tell a missing option from an empty one. The parser's "not found" warning also landed on stdout, corrupting the value the command exists to produce.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines