Add common.compat alias for BaseEventTrigger - #72140
Open
amoghrajesh wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
Each provider repeats a variant of:
Several of these also drag
TriggerEventinto the version branch even though it exists in both 2.x and 3.x, and pull in anAIRFLOW_V_3_0_PLUSimport that isn't used elsewhere.I am proposing that we add a
airflow.providers.common.compat.triggers, which resolvesBaseEventTriggerthrough the existingcreate_module_getattrrename machinery and falls back toBaseTriggeron Airflow 2.x. Call sites collapse to a single import.The iceberg trigger is migrated as the first consumer: #71387
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.