Fix hierarchical_alphabetical sort order breaking the graph and grid - #72137
Open
pierrejeambrun wants to merge 1 commit into
Open
Fix hierarchical_alphabetical sort order breaking the graph and grid#72137pierrejeambrun wants to merge 1 commit into
pierrejeambrun wants to merge 1 commit into
Conversation
The serialized task group the UI renders only re-implemented the topological sort order, so selecting [api] grid_view_sorting_order = hierarchical_alphabetical called a method that does not exist on it and raised AttributeError, failing the whole graph/grid render instead of ordering groups and tasks alphabetically.
pierrejeambrun
force-pushed
the
fix-hierarchical-alphabetical-grid-sort
branch
from
August 27, 2026 10:23
e2981b3 to
25d6863
Compare
Member
Author
|
pierrejeambrun
marked this pull request as ready for review
August 27, 2026 16:14
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only
topological_sortwas ported toSerializedTaskGroup—hierarchical_alphabetical_sortexists solely on the task-SDKTaskGroup. So selectinghierarchical_alphabeticalcalls a method that doesn't exist on the class the UI renders:500s the whole graph/grid.Fix
Implement
hierarchical_alphabetical_sortonSerializedTaskGroup, mirroring the task-SDK version (groups first, then tasks, each alphabetical bynode_id).With this,
[api] grid_view_sorting_order = hierarchical_alphabeticalorders tasks and nested TaskGroups alphabetically in both the graph and grid.Reproduced
On
main,hasattr(SerializedTaskGroup, "hierarchical_alphabetical_sort")isFalse; calling the UI getter under that config raises theAttributeErrorabove. The added test fails without the fix (sameAttributeError) and asserts the alphabetical order with it.closes: #72114
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines