Skip to content

Fix DAG details active runs count to exclude queued runs #69769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vishwaspatel2401 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Fix DAG details active runs count to exclude queued runs #69769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions airflow-core/newsfragments/69769.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix DAG details 'active runs' count to only include running runs, not queued ones, matching scheduler enforcement of max_active_runs
2 changes: 1 addition & 1 deletion airflow-core/src/airflow/api_fastapi/core_api/routes/public/dags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ def get_dag_details(
session.scalar(
select(func.count())
.select_from(DagRun)
.where(DagRun.dag_id == dag_id, DagRun.state.in_([DagRunState.RUNNING, DagRunState.QUEUED]))
.where(DagRun.dag_id == dag_id, DagRun.state == DagRunState.RUNNING)
)
or 0
)
Expand Down
2 changes: 1 addition & 1 deletion airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1278,7 +1278,7 @@ def test_dag_details_includes_active_runs_count(self, session, test_client):
# Verify active_runs_count field is present and correct
assert "active_runs_count" in body
assert isinstance(body["active_runs_count"], int)
assert body["active_runs_count"] == 2 # 1 running + 1 queued
assert body["active_runs_count"] == 1 # only running counts, queued does not

# Test with DAG that has no active runs
response = test_client.get(f"/dags/{DAG1_ID}/details")
Expand Down